Provide write_entry_bytes

This complements the entry API of the encoder with the byte slice based
method. Note we don't provide it for writing raw data, here a
`std::io::Write` would be more appropriate and we should not attempt to
make it `write_all`, nor compress. You'd get all the benefits of the
other API through `[u8]: TiffValue` since that interface is otherwise
type agnostic and `u8` specifically is endian agnostic.
This commit is contained in:
A. Molzer committed 2026-01-11 22:59:34 +01:00
1 parent 9d409433e8
commit 9a23090b6e
2 files changed
+31

No files matched your search

+27
View File
@@ -396,6 +396,33 @@ impl<'a, W: 'a + Write + Seek, K: TiffKind> DirectoryEncoder<'a, W, K> {
) )
} }
/// Write a directory entry by its byte data.
///
/// The data must be pre-formatted to the byte order expected by the file.
///
/// Returns an [`Entry`]. If the value is short enough it will *not* be written in the file but
/// stored in the entry's offset field.
pub fn write_entry_bytes(&mut self, ty: Type, data: &[u8]) -> TiffResult<Entry> {
if data.len() % usize::from(ty.byte_len()) != 0 {
return Err(TiffError::UsageError(UsageError::MismatchedEntryLength {
ty,
found: data.len(),
}));
}
let count = data.len() / usize::from(ty.byte_len());
let count = u64::try_from(count)?;
Self::write_entry_inner(
self.writer,
DirectoryEntry {
data_type: ty,
count: K::convert_offset(count)?,
data: data.into(),
},
)
}
/// Insert previously written key-value entries. /// Insert previously written key-value entries.
/// ///
/// It is the caller's responsibility to ensure that the data referred to by the entries is /// It is the caller's responsibility to ensure that the data referred to by the entries is
+4
View File
@@ -5,6 +5,7 @@ use std::string;
use quick_error::quick_error; use quick_error::quick_error;
use crate::decoder::ChunkType; use crate::decoder::ChunkType;
use crate::tags::Type;
use crate::tags::{ use crate::tags::{
CompressionMethod, PhotometricInterpretation, PlanarConfiguration, SampleFormat, Tag, CompressionMethod, PhotometricInterpretation, PlanarConfiguration, SampleFormat, Tag,
}; };
@@ -211,6 +212,9 @@ quick_error! {
ByteOrderMismatch { ByteOrderMismatch {
display("attempted to use data with a byte order that does not match the required one") display("attempted to use data with a byte order that does not match the required one")
} }
MismatchedEntryLength {ty: Type, found: usize } {
display("the length of data is not a multiple of the size of the type {ty:?}, found {found}")
}
} }
} }