From 07e8501ad60a0e309862596738f419c0bb16bf44 Mon Sep 17 00:00:00 2001 From: Andreas Molzer Date: Tue, 12 Nov 2019 10:53:38 +0100 Subject: [PATCH] Prefer matching over if-else-chain in tags macro Thanks to the review comment for pointing this style issue out. --- src/decoder/ifd.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/decoder/ifd.rs b/src/decoder/ifd.rs index f162f8b..2be016b 100644 --- a/src/decoder/ifd.rs +++ b/src/decoder/ifd.rs @@ -34,8 +34,9 @@ macro_rules! tags { impl $name { #[inline(always)] fn __from_inner_type(n: $ty) -> Result { - $(if n == $val { Ok($name::$tag) } else)* { - Err(n) + match n { + $( $val => Ok($name::$tag), )* + n => Err(n), } }